fix: 코드 리뷰 기반 보안·안정성 개선 (14건)
All checks were successful
Server CI/CD / deploy (push) Successful in 1m36s

- unsafe 타입 단언 → safe assertion (chain handler 11곳, auth Logout)
- Repository 에러 시 nil 반환으로 통일 (chain, auth, announcement)
- string ID → uint 파싱으로 타입 안전성 확보 (auth, announcement)
- CORS AllowHeaders에 Idempotency-Key, X-API-Key 추가
- /verify 엔드포인트 rate limiter 적용
- Redis 호출에 context timeout 적용 (auth, idempotency 미들웨어)
- chain handler 에러 응답에서 내부 정보 노출 방지
- f.Close() 에러 검사 추가 (download service 2곳)
- 공지사항 Delete 404 응답 추가
- 회원가입 롤백 시 Delete 에러 로깅

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-12 14:43:19 +09:00
parent 3d0c9e5670
commit 23bec776ab
14 changed files with 274 additions and 89 deletions

View File

@@ -12,8 +12,10 @@ func NewRepository(db *gorm.DB) *Repository {
func (r *Repository) FindByUsername(username string) (*User, error) {
var user User
err := r.db.Where("username = ?", username).First(&user).Error
return &user, err
if err := r.db.Where("username = ?", username).First(&user).Error; err != nil {
return nil, err
}
return &user, nil
}
func (r *Repository) Create(user *User) error {
@@ -26,22 +28,26 @@ func (r *Repository) FindAll() ([]User, error) {
return users, err
}
func (r *Repository) FindByID(id string) (*User, error) {
func (r *Repository) FindByID(id uint) (*User, error) {
var user User
err := r.db.First(&user, id).Error
return &user, err
if err := r.db.First(&user, id).Error; err != nil {
return nil, err
}
return &user, nil
}
func (r *Repository) UpdateRole(id string, role Role) error {
func (r *Repository) UpdateRole(id uint, role Role) error {
return r.db.Model(&User{}).Where("id = ?", id).Update("role", role).Error
}
func (r *Repository) Delete(id string) error {
func (r *Repository) Delete(id uint) error {
return r.db.Delete(&User{}, id).Error
}
func (r *Repository) FindBySsafyID(ssafyID string) (*User, error) {
var user User
err := r.db.Where("ssafy_id = ?", ssafyID).First(&user).Error
return &user, err
if err := r.db.Where("ssafy_id = ?", ssafyID).First(&user).Error; err != nil {
return nil, err
}
return &user, nil
}